[clang] [clang] Move two flags from EvalInfo to State (PR #157046)

[Timm Baeder via cfe-commits]

================
@@ -960,19 +947,6 @@ namespace {
       EM_IgnoreSideEffects,
     } EvalMode;
 
-    /// Are we checking whether the expression is a potential constant
-    /// expression?
-    bool checkingPotentialConstantExpression() const override  {
-      return CheckingPotentialConstantExpression;
-    }
-
-    /// Are we checking an expression for overflow?
-    // FIXME: We should check for any kind of undefined or suspicious behavior
-    // in such constructs, not just overflow.
----------------
tbaederr wrote:

I assumed this was fixed in the past since the function isn't called `checkingForOverflow`. But now that I look at it again, the function name might've been inverted?

https://github.com/llvm/llvm-project/pull/157046