[clang] [clang-tools-extra] [llvm] [ADT] Refactor StringMap iterators (NFC) (PR #156137)

[via cfe-commits]

github-actions[bot] wrote:

<!--LLVM CODE FORMAT COMMENT: {clang-format}-->


:warning: C/C++ code formatter, clang-format found issues in your code. :warning:

<details>
<summary>
You can test this locally with the following command:
</summary>

``````````bash
git-clang-format --diff origin/main HEAD --extensions h,cpp -- clang-tools-extra/clang-tidy/fuchsia/MultipleInheritanceCheck.cpp clang/lib/Driver/OffloadBundler.cpp llvm/include/llvm/ADT/StringMap.h llvm/unittests/ADT/StringMapTest.cpp
``````````

:warning:
The reproduction instructions above might return results for more than one PR
in a stack if you are using a stacked PR workflow. You can limit the results by
changing `origin/main` to the base branch/commit you want to compare against.
:warning:

</details>

<details>
<summary>
View the diff from clang-format here.
</summary>

``````````diff
diff --git a/llvm/unittests/ADT/StringMapTest.cpp b/llvm/unittests/ADT/StringMapTest.cpp
index 2490a400f..92ae364d4 100644
--- a/llvm/unittests/ADT/StringMapTest.cpp
+++ b/llvm/unittests/ADT/StringMapTest.cpp
@@ -707,12 +707,10 @@ TEST(StringMapCustomTest, NonConstIterator) {
       "The value_type of a non-const iterator should not be a const type.");
 
   // Check that pointer and reference types are not const.
-  static_assert(
-      std::is_same_v<StringMap<int>::iterator::pointer,
-                     StringMap<int>::iterator::value_type *>);
-  static_assert(
-      std::is_same_v<StringMap<int>::iterator::reference,
-                     StringMap<int>::iterator::value_type &>);
+  static_assert(std::is_same_v<StringMap<int>::iterator::pointer,
+                               StringMap<int>::iterator::value_type *>);
+  static_assert(std::is_same_v<StringMap<int>::iterator::reference,
+                               StringMap<int>::iterator::value_type &>);
 
   // Check that we can construct a const_iterator from an iterator.
   static_assert(std::is_constructible_v<StringMap<int>::const_iterator,

``````````

</details>


https://github.com/llvm/llvm-project/pull/156137