[clang] [clang-tools-extra] [llvm] [ADT] Refactor StringMap iterators (NFC) (PR #156137)

[Kazu Hirata via cfe-commits]

kazutakahirata wrote:

> Maybe we could add some tests with `is_same_v` to check that the types are as expected, e.g., that dereferencing const iterator give you the right const reference etc?

@kuhar Good idea!  I've added a couple of tests about iterator types.  Please take a look.  Thanks in advance!

https://github.com/llvm/llvm-project/pull/156137