[clang-tools-extra] [clang-tidy][NFC] Enable 'readability-redundant-declaration' check in clang-tidy config (PR #156164)

[Baranov Victor via cfe-commits]

https://github.com/vbvictor created https://github.com/llvm/llvm-project/pull/156164

Closes https://github.com/llvm/llvm-project/issues/156163

>From b3aa1b3c24680dcaff3dee3ec5f82a23b343b018 Mon Sep 17 00:00:00 2001
From: Victor Baranov <bar.victor.2002 at gmail.com>
Date: Sat, 30 Aug 2025 11:13:44 +0300
Subject: [PATCH] [clang-tidy][NFC] Enable 'readability-redundant-declaration'
 check in clang-tidy config.

---
 clang-tools-extra/clang-tidy/.clang-tidy                    | 1 -
 .../clang-tidy/readability/UppercaseLiteralSuffixCheck.cpp  | 6 ------
 2 files changed, 7 deletions(-)

diff --git a/clang-tools-extra/clang-tidy/.clang-tidy b/clang-tools-extra/clang-tidy/.clang-tidy
index 22a4bd7d80618..0e33364442e76 100644
--- a/clang-tools-extra/clang-tidy/.clang-tidy
+++ b/clang-tools-extra/clang-tidy/.clang-tidy
@@ -32,7 +32,6 @@ Checks: >
   -readability-magic-numbers,
   -readability-named-parameter,
   -readability-qualified-auto,
-  -readability-redundant-declaration,
   -readability-simplify-boolean-expr,
   -readability-static-definition-in-anonymous-namespace,
   -readability-suspicious-call-argument,
diff --git a/clang-tools-extra/clang-tidy/readability/UppercaseLiteralSuffixCheck.cpp b/clang-tools-extra/clang-tidy/readability/UppercaseLiteralSuffixCheck.cpp
index 678aa8dad48a7..3535a1de3e022 100644
--- a/clang-tools-extra/clang-tidy/readability/UppercaseLiteralSuffixCheck.cpp
+++ b/clang-tools-extra/clang-tidy/readability/UppercaseLiteralSuffixCheck.cpp
@@ -30,9 +30,6 @@ struct IntegerLiteralCheck {
   static constexpr llvm::StringLiteral Suffixes =
       llvm::StringLiteral("uUlLiIjJ");
 };
-constexpr llvm::StringLiteral IntegerLiteralCheck::Name;
-constexpr llvm::StringLiteral IntegerLiteralCheck::SkipFirst;
-constexpr llvm::StringLiteral IntegerLiteralCheck::Suffixes;
 
 struct FloatingLiteralCheck {
   using type = clang::FloatingLiteral;
@@ -50,9 +47,6 @@ struct FloatingLiteralCheck {
   static constexpr llvm::StringLiteral Suffixes =
       llvm::StringLiteral("fFlLhHqQiIjJ");
 };
-constexpr llvm::StringLiteral FloatingLiteralCheck::Name;
-constexpr llvm::StringLiteral FloatingLiteralCheck::SkipFirst;
-constexpr llvm::StringLiteral FloatingLiteralCheck::Suffixes;
 
 struct NewSuffix {
   SourceRange LiteralLocation;