[clang] [clang][SPIRV] Default AS generic for Intel-flavored SPIR-V (PR #153647)

[Nick Sarnie via cfe-commits]

================
@@ -219,8 +219,11 @@ class LLVM_LIBRARY_VISIBILITY BaseSPIRTargetInfo : public TargetInfo {
     setAddressSpaceMap(
         /*DefaultIsGeneric=*/Opts.SYCLIsDevice ||
         // The address mapping from HIP/CUDA language for device code is only
-        // defined for SPIR-V.
-        (getTriple().isSPIRV() && Opts.CUDAIsDevice));
+        // defined for SPIR-V, and all Intel SPIR-V code should have the default
+        // AS as generic.
+        (getTriple().isSPIRV() &&
----------------
sarnex wrote:

yeah i did zero investigation, here's the full list in case anyone cares

```
********************
Failed Tests (35):
  Clang :: CodeGen/scoped-atomic-ops.c
  Clang :: CodeGen/scoped-fence-ops.c
  Clang :: CodeGenHLSL/GlobalDestructors.hlsl
  Clang :: CodeGenHLSL/HLSLControlFlowHint.hlsl
  Clang :: CodeGenHLSL/builtins/clip.hlsl
  Clang :: CodeGenHLSL/builtins/dot2add.hlsl
  Clang :: CodeGenHLSL/builtins/dot4add_i8packed.hlsl
  Clang :: CodeGenHLSL/builtins/dot4add_u8packed.hlsl
  Clang :: CodeGenHLSL/builtins/mad.hlsl
  Clang :: CodeGenHLSL/builtins/splitdouble.hlsl
  Clang :: CodeGenHLSL/out-of-line-static.hlsl
  Clang :: CodeGenHLSL/resources/AppendStructuredBuffer-elementtype.hlsl
  Clang :: CodeGenHLSL/resources/ConsumeStructuredBuffer-elementtype.hlsl
  Clang :: CodeGenHLSL/resources/RWBuffer-constructor-opt.hlsl
  Clang :: CodeGenHLSL/resources/RWBuffer-elementtype.hlsl
  Clang :: CodeGenHLSL/resources/RWBuffer-subscript.hlsl
  Clang :: CodeGenHLSL/resources/RWStructuredBuffer-elementtype.hlsl
  Clang :: CodeGenHLSL/resources/StructuredBuffer-elementtype.hlsl
  Clang :: CodeGenHLSL/resources/StructuredBuffers-subscripts.hlsl
  Clang :: CodeGenHLSL/resources/default_cbuffer.hlsl
  Clang :: CodeGenHLSL/vk-features/SpirvType.hlsl
  Clang :: CodeGenHLSL/vk-features/vk.spec-constant.hlsl
  Clang :: CodeGenHLSL/vk-input-builtin.hlsl
  Clang :: CodeGenHLSL/vk_binding_attr.hlsl
  Clang :: CodeGenSYCL/address-space-conversions.cpp
  Clang :: CodeGenSYCL/address-space-deduction.cpp
  Clang :: CodeGenSYCL/address-space-mangling.cpp
  Clang :: CodeGenSYCL/debug-info-kernel-variables.cpp
  Clang :: CodeGenSYCL/field-annotate-addr-space.cpp
  Clang :: CodeGenSYCL/function-attrs.cpp
  Clang :: CodeGenSYCL/functionptr-addrspace.cpp
  Clang :: CodeGenSYCL/kernel-caller-entry-point.cpp
  Clang :: CodeGenSYCL/unique_stable_name.cpp
  Clang :: CodeGenSYCL/unique_stable_name_windows_diff.cpp
  Clang :: OpenMP/target_num_teams_num_threads_attributes.cpp

```

https://github.com/llvm/llvm-project/pull/153647