[clang] [clang][SPIRV] Default AS generic for Intel-flavored SPIR-V (PR #153647)

Nick Sarnie via cfe-commits cfe-commits at lists.llvm.org
Mon Aug 25 07:29:48 PDT 2025


================
@@ -219,8 +219,11 @@ class LLVM_LIBRARY_VISIBILITY BaseSPIRTargetInfo : public TargetInfo {
     setAddressSpaceMap(
         /*DefaultIsGeneric=*/Opts.SYCLIsDevice ||
         // The address mapping from HIP/CUDA language for device code is only
-        // defined for SPIR-V.
-        (getTriple().isSPIRV() && Opts.CUDAIsDevice));
+        // defined for SPIR-V, and all Intel SPIR-V code should have the default
+        // AS as generic.
+        (getTriple().isSPIRV() &&
----------------
sarnex wrote:

ok if i make the entire condition `!Opts.OpenCL && getTriple().isSPIRV()` we get 35 LIT fails covering HLSL, SYCL and OpenMP. It's possible these are all just test updates, but I'd prefer to be safe and stick with the very specific condition I have in the PR as-is, let me know if you disagree.

https://github.com/llvm/llvm-project/pull/153647


More information about the cfe-commits mailing list