[clang] [Driver] Fix out of place comment (PR #155001)

Marco Elver via cfe-commits cfe-commits at lists.llvm.org
Fri Aug 22 11:12:49 PDT 2025


https://github.com/melver created https://github.com/llvm/llvm-project/pull/155001

The unrelated code was added in between the comment and what it is meant to document. Move the comment.

NFC.

>From 74c4a81adefcad934416564faa2df0c4c139ae76 Mon Sep 17 00:00:00 2001
From: Marco Elver <elver at google.com>
Date: Fri, 22 Aug 2025 20:04:58 +0200
Subject: [PATCH] [Driver] Fix out of place comment

The unrelated code was added in between the comment and what it is meant
to document. Move the comment.

NFC.
---
 clang/lib/Driver/ToolChains/Clang.cpp | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/clang/lib/Driver/ToolChains/Clang.cpp b/clang/lib/Driver/ToolChains/Clang.cpp
index 29b7180df5cb5..e8181dca59c17 100644
--- a/clang/lib/Driver/ToolChains/Clang.cpp
+++ b/clang/lib/Driver/ToolChains/Clang.cpp
@@ -5981,12 +5981,13 @@ void Clang::ConstructJob(Compilation &C, const JobAction &JA,
 
   Args.AddLastArg(CmdArgs, options::OPT_fno_knr_functions);
 
-  // This is a coarse approximation of what llvm-gcc actually does, both
-  // -fasynchronous-unwind-tables and -fnon-call-exceptions interact in more
-  // complicated ways.
   auto SanitizeArgs = TC.getSanitizerArgs(Args);
   Args.AddLastArg(CmdArgs,
                   options::OPT_fallow_runtime_check_skip_hot_cutoff_EQ);
+
+  // This is a coarse approximation of what llvm-gcc actually does, both
+  // -fasynchronous-unwind-tables and -fnon-call-exceptions interact in more
+  // complicated ways.
   bool IsAsyncUnwindTablesDefault =
       TC.getDefaultUnwindTableLevel(Args) == ToolChain::UnwindTableLevel::Asynchronous;
   bool IsSyncUnwindTablesDefault =



More information about the cfe-commits mailing list