[clang] 9a692e0 - [clang-format] Don't annotate class property specifiers as StartOfName (#153525)
via cfe-commits
cfe-commits at lists.llvm.org
Sun Aug 17 12:54:01 PDT 2025
Author: owenca
Date: 2025-08-17T12:53:57-07:00
New Revision: 9a692e0f94a99abea781397da5629336c74e8f8e
URL: https://github.com/llvm/llvm-project/commit/9a692e0f94a99abea781397da5629336c74e8f8e
DIFF: https://github.com/llvm/llvm-project/commit/9a692e0f94a99abea781397da5629336c74e8f8e.diff
LOG: [clang-format] Don't annotate class property specifiers as StartOfName (#153525)
Fixes #153443
Added:
Modified:
clang/lib/Format/TokenAnnotator.cpp
clang/unittests/Format/TokenAnnotatorTest.cpp
Removed:
################################################################################
diff --git a/clang/lib/Format/TokenAnnotator.cpp b/clang/lib/Format/TokenAnnotator.cpp
index 4801d27b1395a..88752903914bf 100644
--- a/clang/lib/Format/TokenAnnotator.cpp
+++ b/clang/lib/Format/TokenAnnotator.cpp
@@ -2590,6 +2590,9 @@ class AnnotatingParser {
if (!Tok.Previous || Tok.isNot(tok::identifier) || Tok.is(TT_ClassHeadName))
return false;
+ if (Tok.endsSequence(Keywords.kw_final, TT_ClassHeadName))
+ return false;
+
if ((Style.isJavaScript() || Style.isJava()) && Tok.is(Keywords.kw_extends))
return false;
diff --git a/clang/unittests/Format/TokenAnnotatorTest.cpp b/clang/unittests/Format/TokenAnnotatorTest.cpp
index 7f99655b1fa49..85ccba38ac8ca 100644
--- a/clang/unittests/Format/TokenAnnotatorTest.cpp
+++ b/clang/unittests/Format/TokenAnnotatorTest.cpp
@@ -618,6 +618,13 @@ TEST_F(TokenAnnotatorTest, UnderstandsStructs) {
EXPECT_TOKEN(Tokens[19], tok::l_brace, TT_StructLBrace);
EXPECT_TOKEN(Tokens[20], tok::r_brace, TT_StructRBrace);
+ Tokens = annotate("class Outer {\n"
+ " struct Inner final : Base {};\n"
+ "};");
+ ASSERT_EQ(Tokens.size(), 14u) << Tokens;
+ EXPECT_TOKEN(Tokens[5], tok::identifier, TT_Unknown); // Not TT_StartOfName
+ EXPECT_TOKEN(Tokens[6], tok::colon, TT_InheritanceColon);
+
constexpr StringRef Code("struct EXPORT StructName {};");
Tokens = annotate(Code);
More information about the cfe-commits
mailing list