[clang] [clang-tools-extra] [clang] Skip suggesting unqualified members in explicit-object member functions (PR #153760)

[Mythreya Kuricheti via cfe-commits]

================
@@ -1428,6 +1428,16 @@ void ResultBuilder::AddResult(Result R, DeclContext *CurContext,
 
   AdjustResultPriorityForDecl(R);
 
+  if (isa<FieldDecl>(R.Declaration)) {
+    // If result is a member in the context of an explicit-object member
+    // function, drop it because it must be accessed through the object
+    // parameter
+    if (auto *MethodDecl = dyn_cast<CXXMethodDecl>(CurContext);
----------------
MythreyaK wrote:

> This scenario involves CodeCompleteMemberReferencExpr, so I don't think it needs to influence what we do in CodeCompleteOrdinaryName.

Sounds good!

>  Let's file it as another issue to look at later?

Looks like it's the first part of #109608. 

https://github.com/llvm/llvm-project/pull/153760