[clang] [clang-tools-extra] [clang] Skip suggesting unqualified members in explicit-object member functions (PR #153760)

[Mythreya Kuricheti via cfe-commits]

================
@@ -1428,6 +1428,16 @@ void ResultBuilder::AddResult(Result R, DeclContext *CurContext,
 
   AdjustResultPriorityForDecl(R);
 
+  if (isa<FieldDecl>(R.Declaration)) {
+    // If result is a member in the context of an explicit-object member
+    // function, drop it because it must be accessed through the object
+    // parameter
+    if (auto *MethodDecl = dyn_cast<CXXMethodDecl>(CurContext);
----------------
MythreyaK wrote:

Good catch, yeah, I failed to consider this :thinking:. 

Is storing it with a call to `setObjectTypeQualifiers` fine? Or is introducing a new get-set pair better? 

https://github.com/llvm/llvm-project/pull/153760