[clang] [CIR] Upstream GotoOp (PR #153701)

Andy Kaylor via cfe-commits cfe-commits at lists.llvm.org
Thu Aug 14 17:26:11 PDT 2025


================
@@ -433,6 +435,25 @@ mlir::LogicalResult CIRGenFunction::emitReturnStmt(const ReturnStmt &s) {
   return mlir::success();
 }
 
+mlir::LogicalResult CIRGenFunction::emitGotoStmt(const clang::GotoStmt &s) {
+  // FIXME: LLVM codegen inserts emit stop point here for debug info
+  // sake when the insertion point is available, but doesn't do
+  // anything special when there isn't. We haven't implemented debug
+  // info support just yet, look at this again once we have it.
+  if (!builder.getInsertionBlock())
----------------
andykaylor wrote:

```suggestion
  assert(!cir::MissingFeatures::generateDebugInfo());
```
This seems backwards. According to the comment, the stop point is only needed when we have an insertion point. I think it's better to just put a missing feature marker here.


https://github.com/llvm/llvm-project/pull/153701


More information about the cfe-commits mailing list