[clang-tools-extra] Update debug output string (PR #152671)

Mythreya Kuricheti via cfe-commits cfe-commits at lists.llvm.org
Fri Aug 8 02:03:02 PDT 2025


https://github.com/MythreyaK created https://github.com/llvm/llvm-project/pull/152671

Include `Signature` and `SnippetSuffix` in the output, when test fails


Before: <pre><code>Value of: Result.Completions
Expected: has 1 element that (named (Name: "bar")) and (signature (S: "(A self, int arg)")) and (snippet suffix (Text: "(${1:A self}, ${2:int arg})"))
  Actual: {  bar - {"detail":"void","filterText":"bar","insertText":"bar","insertTextFormat":1,"kind":2,"label":" bar","labelDetails":{"detail":"(int arg)"},"score":0.65507817268371582,"sortText":"40d84cccbar","textEdit":{"newText":"bar","range":{"end":{"character":13,"line":10},"start":{"character":11,"line":10}}}} }, whose element #0 doesn't match
</code></pre>

After: <pre><code>Value of: Result.Completions
Expected: has 1 element that (named (Name: "bar")) and (signature (S: "(A self, int arg)")) and (snippet suffix (Text: "(${1:A self}, ${2:int arg})"))
  Actual: { <mark>Signature: "(A self, int arg)", SnippetSuffix: "", Rendered:</mark> bar - {"detail":"void","filterText":"bar","insertText":"bar","insertTextFormat":1,"kind":2,"label":" bar","labelDetails":{"detail":"(A self, int arg)"},"score":0.65507817268371582,"sortText":"40d84cccbar","textEdit":{"newText":"bar","range":{"end":{"character":13,"line":10},"start":{"character":11,"line":10}}}} }, whose element #0 doesn't match
</code></pre>

>From 27ddf058840ea66ffb401e3d4cfb3099d3051b0e Mon Sep 17 00:00:00 2001
From: Mythreya Kuricheti <git at mythreya.dev>
Date: Fri, 8 Aug 2025 01:58:15 -0700
Subject: [PATCH] Update debug output string

Include signature and snippetSuffix in the output, when test fails
---
 clang-tools-extra/clangd/CodeComplete.cpp | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/clang-tools-extra/clangd/CodeComplete.cpp b/clang-tools-extra/clangd/CodeComplete.cpp
index 9c17b4ca9b706..cacff21e155a7 100644
--- a/clang-tools-extra/clangd/CodeComplete.cpp
+++ b/clang-tools-extra/clangd/CodeComplete.cpp
@@ -2434,6 +2434,9 @@ CompletionItem CodeCompletion::render(const CodeCompleteOptions &Opts) const {
 }
 
 llvm::raw_ostream &operator<<(llvm::raw_ostream &OS, const CodeCompletion &C) {
+  OS << "Signature: " << "\"" << C.Signature << "\", "
+     << "SnippetSuffix: " << "\"" << C.SnippetSuffix << "\""
+     << ", Rendered:";
   // For now just lean on CompletionItem.
   return OS << C.render(CodeCompleteOptions());
 }



More information about the cfe-commits mailing list