[clang-tools-extra] [clang-tidy] Added check 'misc-visibility-change-to-virtual-function' (PR #140086)

[Baranov Victor via cfe-commits]

=?utf-8?q?Balázs_Kéri?= <balazs.keri at ericsson.com>,
=?utf-8?q?Balázs_Kéri?= <balazs.keri at ericsson.com>,
=?utf-8?q?Balázs_Kéri?= <balazs.keri at ericsson.com>,
=?utf-8?q?Balázs_Kéri?= <balazs.keri at ericsson.com>,
=?utf-8?q?Balázs_Kéri?= <balazs.keri at ericsson.com>,
=?utf-8?q?Balázs_Kéri?= <balazs.keri at ericsson.com>,
=?utf-8?q?Balázs_Kéri?= <balazs.keri at ericsson.com>,
=?utf-8?q?Balázs_Kéri?= <balazs.keri at ericsson.com>,
=?utf-8?q?Balázs_Kéri?= <balazs.keri at ericsson.com>
Message-ID:
In-Reply-To: <llvm.org/llvm/llvm-project/pull/140086 at github.com>


vbvictor wrote:

I slightly don't like words consistent/inconsistent in check name because its meaning can vary from person to person.
To be unambiguous, my choice is `misc-override-with-different-visibility`/`misc-visibility-change-to-virtual-function`/`misc-virtual-function-visibility-change-in-override`. I'd go with any of these three names. If a concrete name is needed pick `misc-override-with-different-visibility`

https://github.com/llvm/llvm-project/pull/140086