[clang-tools-extra] [clang-tidy] Added check 'misc-visibility-change-to-virtual-function' (PR #140086)

[Donát Nagy via cfe-commits]

NagyDonat wrote:

Yet another suggestion for the name: `misc-override-with-different-visibility`. (The word `override` is shorter than `virtual-function` and still clearly identifies the situation where this check is relevant.) However I don't want to make this bikeshedding even longer, so I can accept any other name as well.

_As far as I see, currently the following name suggestions are active:_
- `misc-visibility-change-to-virtual-function` (included in the current revision of the PR)
- `misc-virtual-function-visibility-change-in-override` (https://github.com/llvm/llvm-project/pull/140086#pullrequestreview-3052440841)
- `misc-consistent-virtual-function-visibility` (https://github.com/llvm/llvm-project/pull/140086#issuecomment-3114232481)
- `misc-override-with-different-visibility` (my suggestion in this comment)

_... but there were also three earlier `bugprone-` suggestions in comment https://github.com/llvm/llvm-project/pull/140086#pullrequestreview-2848301903_

@balazske @vbvictor @PiotrZSL @5chmidti @EugeneZelenko @ anybody else interested:
Which name suggestion is the best in your opinion? Which other names would be acceptable as well? Do you know about any other issue with the PR?


https://github.com/llvm/llvm-project/pull/140086