[clang] [NFC][analyzer] Conversion to CheckerFamily: RetainCountChecker (PR #152138)

[Balazs Benics via cfe-commits]

=?utf-8?q?Donát?= Nagy <donat.nagy at ericsson.com>,
=?utf-8?q?Donát?= Nagy <donat.nagy at ericsson.com>
Message-ID:
In-Reply-To: <llvm.org/llvm/llvm-project/pull/152138 at github.com>


steakhal wrote:

> > I'm not too interested reviewing this.
> 
> Completely understandable, I'm uploading quite many boring cleanup commits nowdays :) I'm adding you as a reviewer on them to give you an opportunity to object if you see any glaring issues, but I don't expect you to dig into the details if you are not interested / don't have time for them.

Interpret this in the good way. I trust you, I skimmed through the PR and looks good. If you deem to get a second opinion because it needs some in depth review go for it. Otherwise I'm fine merging. This is what I wanted to mean by this.
More like just disclaiming that I spent like 2 minutes on the review, and I don't really invest more. If you think it deserves more attention get an other reviewer.

> By the way thanks for the inspiration that led to creating this new CheckerFamily framework, it's much more elegant than my earlier "enum + array of checker names" approach. I'm close to finishing this conversion, and I hope that I can do some more substantial change (probably bringing the ReturnPtr and cstring.OutOfBound checkers out of alpha state).

Sounds great!

https://github.com/llvm/llvm-project/pull/152138