[clang] [Clang][attr] Add 'cfi_salt' attribute (PR #141846)

[Erich Keane via cfe-commits]

================
@@ -7941,6 +7942,31 @@ static bool handleFunctionTypeAttr(TypeProcessingState &state, ParsedAttr &attr,
     return true;
   }
 
+  if (attr.getKind() == ParsedAttr::AT_CFISalt) {
+    if (attr.getNumArgs() != 1)
----------------
erichkeane wrote:

I'm still a little surprised we actually GET to this.  I would expect whoever does the diagnostic here should ensure we don't get to this attribute, and I'd like us to understand why that is (that is, that this can get here).

I realize this is all OLD code (this function) that likely was written with different expectations, so I want to make sure we're not using those for not a good reason.

https://github.com/llvm/llvm-project/pull/141846