[clang] [Clang][attr] Add 'cfi_salt' attribute (PR #141846)

[Erich Keane via cfe-commits]

================
@@ -7941,6 +7942,32 @@ static bool handleFunctionTypeAttr(TypeProcessingState &state, ParsedAttr &attr,
     return true;
   }
 
+  if (attr.getKind() == ParsedAttr::AT_CFISalt) {
+    if (attr.getNumArgs() == 0)
+      return true;
+
+    // Delay if this is not a function type.
+    StringRef Argument;
+    if (!S.checkStringLiteralArgumentAttr(attr, 0, Argument))
+      return false;
+
+    // Delay if this is not a function type.
+    if (!unwrapped.isFunctionType())
+      return false;
+
+    const auto *FnTy = unwrapped.get()->getAs<FunctionProtoType>();
+    if (!FnTy)
----------------
erichkeane wrote:

Then my question is: why the `if(!FnTy)`?  Do we have a case where this matters?

Likely a few of the `return`s here should just be asserts.

https://github.com/llvm/llvm-project/pull/141846