[clang] [CIR] Implemented get/set for volatile bitfields (PR #151875)

Andy Kaylor via cfe-commits cfe-commits at lists.llvm.org
Mon Aug 4 11:07:52 PDT 2025


================
@@ -322,22 +322,27 @@ void CIRGenFunction::emitStoreOfScalar(mlir::Value value, Address addr,
   assert(!cir::MissingFeatures::opTBAA());
 }
 
+/// Helper method to check if the underlying ABI is AAPCS
+static bool isAAPCS(const TargetInfo &targetInfo) {
----------------
andykaylor wrote:

This seems like something we should be getting through a TargetInfo function call. I'm not asking you to change that in this PR, but can you add a TODO comment? This will be the fourth place in the code (two in CIR, two in classic codegen) that performs the check this way.

https://github.com/llvm/llvm-project/pull/151875


More information about the cfe-commits mailing list