[clang] [Clang] Fix warning on synthetic offload arch argument in host only mode (PR #151969)
via cfe-commits
cfe-commits at lists.llvm.org
Mon Aug 4 06:57:26 PDT 2025
llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT-->
@llvm/pr-subscribers-clang-driver
Author: Joseph Huber (jhuber6)
<details>
<summary>Changes</summary>
Summary:
These arguments are synthetically generated and should always be
considered used. This was emitting a warning on the new driver.
---
Full diff: https://github.com/llvm/llvm-project/pull/151969.diff
2 Files Affected:
- (modified) clang/lib/Driver/Driver.cpp (+1)
- (modified) clang/test/Driver/hip-options.hip (+1-1)
``````````diff
diff --git a/clang/lib/Driver/Driver.cpp b/clang/lib/Driver/Driver.cpp
index 586f287843f3e..8c0bba938a09b 100644
--- a/clang/lib/Driver/Driver.cpp
+++ b/clang/lib/Driver/Driver.cpp
@@ -1012,6 +1012,7 @@ inferOffloadToolchains(Compilation &C, Action::OffloadKind Kind) {
Arg *A = new Arg(Opt, C.getArgs().getArgString(Index), Index,
C.getArgs().MakeArgString(Triple.split("-").first),
C.getArgs().MakeArgString("--offload-arch=" + Arch));
+ A->claim();
C.getArgs().append(A);
C.getArgs().AddSynthesizedArg(A);
Triples.insert(Triple);
diff --git a/clang/test/Driver/hip-options.hip b/clang/test/Driver/hip-options.hip
index ba23bc2d59b56..6206020d76db6 100644
--- a/clang/test/Driver/hip-options.hip
+++ b/clang/test/Driver/hip-options.hip
@@ -241,7 +241,7 @@
// Check --offload-compress --offload-jobs=N does not cause warning.
// RUN: %clang -### -Werror --target=x86_64-unknown-linux-gnu -nogpuinc -nogpulib \
// RUN: --offload-arch=gfx1100 --offload-compress --offload-host-only -M %s \
-// RUN: --offload-jobs=4
+// RUN: --offload-jobs=4 --offload-new-driver
// Check --offload-jobs=N option.
``````````
</details>
https://github.com/llvm/llvm-project/pull/151969
More information about the cfe-commits
mailing list