[clang] [libcxx] [Clang] Add detailed notes explaining why `is_constructible` evaluates to false (Revert 16d5db7) (PR #151935)

[via cfe-commits]

github-actions[bot] wrote:

<!--LLVM CODE FORMAT COMMENT: {clang-format}-->


:warning: C/C++ code formatter, clang-format found issues in your code. :warning:

<details>
<summary>
You can test this locally with the following command:
</summary>

``````````bash
git-clang-format --diff HEAD~1 HEAD --extensions cpp,h -- clang/lib/Sema/SemaTypeTraits.cpp clang/test/CXX/drs/cwg18xx.cpp clang/test/SemaCXX/overload-resolution-deferred-templates.cpp clang/test/SemaCXX/type-traits-unsatisfied-diags-std.cpp clang/test/SemaCXX/type-traits-unsatisfied-diags.cpp libcxx/include/__expected/expected.h libcxx/test/libcxx/utilities/expected/expected.expected/and_then.mandates.verify.cpp libcxx/test/libcxx/utilities/expected/expected.expected/or_else.mandates.verify.cpp libcxx/test/libcxx/utilities/expected/expected.expected/value.observers.verify.cpp libcxx/test/libcxx/utilities/expected/expected.void/and_then.mandates.verify.cpp libcxx/test/std/containers/sequences/array/array.creation/to_array.verify.cpp libcxx/test/std/containers/views/mdspan/mdspan/conversion.verify.cpp libcxx/test/std/utilities/function.objects/func.bind.partial/bind_back.verify.cpp libcxx/test/std/utilities/function.objects/func.bind_front/bind_front.verify.cpp
``````````

</details>

<details>
<summary>
View the diff from clang-format here.
</summary>

``````````diff
diff --git a/libcxx/include/__expected/expected.h b/libcxx/include/__expected/expected.h
index 5061e1703..bb0178245 100644
--- a/libcxx/include/__expected/expected.h
+++ b/libcxx/include/__expected/expected.h
@@ -845,7 +845,7 @@ public:
   }
 
   _LIBCPP_HIDE_FROM_ABI constexpr const _Tp&& value() const&& {
-    static_assert(bool(is_copy_constructible_v<_Err> && is_constructible_v<_Err, decltype(std::move(error())))>,
+    static_assert(bool(is_copy_constructible_v<_Err> && is_constructible_v < _Err, decltype(std::move(error()))) >,
                   "error_type has to be both copy constructible and constructible from decltype(std::move(error()))");
     if (!this->__has_val()) {
       std::__throw_bad_expected_access<_Err>(std::move(error()));
@@ -854,7 +854,7 @@ public:
   }
 
   _LIBCPP_HIDE_FROM_ABI constexpr _Tp&& value() && {
-    static_assert(bool(is_copy_constructible_v<_Err> && is_constructible_v<_Err, decltype(std::move(error())))>,
+    static_assert(bool(is_copy_constructible_v<_Err> && is_constructible_v < _Err, decltype(std::move(error()))) >,
                   "error_type has to be both copy constructible and constructible from decltype(std::move(error()))");
     if (!this->__has_val()) {
       std::__throw_bad_expected_access<_Err>(std::move(error()));

``````````

</details>


https://github.com/llvm/llvm-project/pull/151935