[clang-tools-extra] [clang-tidy][mlir] Make rewrite more conservative. (PR #150757)

Baranov Victor via cfe-commits cfe-commits at lists.llvm.org
Mon Jul 28 05:35:28 PDT 2025


================
@@ -69,4 +69,7 @@ void f() {
   // CHECK-MESSAGES: :[[@LINE+2]]:3: warning: use 'OpType::create(builder, ...)' instead of 'builder.create<OpType>(...)' [llvm-use-new-mlir-op-builder]
   // CHECK-FIXES: mlir::ModuleOp::create(ib)
   ib.create<mlir::ModuleOp>(   );
+
+  // CHECK-MESSAGES: :[[@LINE+1]]:3: warning: use 'OpType::create(builder, ...)' instead of 'builder.create<OpType>(...)' [llvm-use-new-mlir-op-builder]
----------------
vbvictor wrote:

Given that `FileCheck` oddly doesn't enforce that line 74 is left unchanged, you could write
`// CHECK-FIXES: mlir::OpBuilder().create<mlir::ModuleOp>(builder.getUnknownLoc());` to explicitly state that.

https://github.com/llvm/llvm-project/pull/150757


More information about the cfe-commits mailing list