[clang-tools-extra] [clang-tidy] Add MLIR check for old op builder usage. (PR #149148)

[Michał Górny via cfe-commits]

mgorny wrote:

Tons of failures on Gentoo as well:

```
Total Discovered Tests: 1352
  Unsupported      :   8 (0.59%)
  Passed           : 399 (29.51%)
  Expectedly Failed:   1 (0.07%)
  Failed           : 944 (69.82%)
```

At a quick glance, they look like something's segfaulting on exit:

```
FAIL: Clang Tools :: clang-tidy/checkers/abseil/faster-strsplit-delimiter.cpp (90 of 1270)
******************** TEST 'Clang Tools :: clang-tidy/checkers/abseil/faster-strsplit-delimiter.cpp' FAILED ********************
Exit Code: 1

Command Output (stdout):
--
Running ['clang-tidy', '/var/tmp/portage/llvm-core/clang-22.0.0.9999/work/x/y/clang-abi_x86_64.amd64/tools/extra/test/clang-tidy/checke
rs/abseil/Output/faster-strsplit-delimiter.cpp.tmp.cpp', '-fix', '--checks=-*,abseil-faster-strsplit-delimiter', '--config={}', '--', '
-std=c++11', '-nostdinc++']...
clang-tidy /var/tmp/portage/llvm-core/clang-22.0.0.9999/work/x/y/clang-abi_x86_64.amd64/tools/extra/test/clang-tidy/checkers/abseil/Out
put/faster-strsplit-delimiter.cpp.tmp.cpp -fix --checks=-*,abseil-faster-strsplit-delimiter --config={} -- -std=c++11 -nostdinc++ faile
d:
14 warnings generated.
/var/tmp/portage/llvm-core/clang-22.0.0.9999/work/x/y/clang-abi_x86_64.amd64/tools/extra/test/clang-tidy/checkers/abseil/Output/faster-
strsplit-delimiter.cpp.tmp.cpp:42:25: warning: absl::StrSplit() called with a string literal consisting of a single character; consider
 using the character overload [abseil-faster-strsplit-delimiter]
   42 |   absl::StrSplit("ABC", "A");
      |                         ^~~
      |                         'A'
[...]
/var/tmp/portage/llvm-core/clang-22.0.0.9999/work/x/y/clang-abi_x86_64.amd64/tools/extra/test/clang-tidy/checkers/abseil/Output/faster-
strsplit-delimiter.cpp.tmp.cpp:116:25: note: FIX-IT applied suggested code changes
clang-tidy applied 14 of 14 suggested fixes.
PLEASE submit a bug report to https://github.com/llvm/llvm-project/issues/ and include the crash backtrace.
#0 0x00007f9426579133 llvm::sys::PrintStackTrace(llvm::raw_ostream&, int) (/usr/lib/llvm/22/lib64/libLLVM.so.22.0git3feb6f97+0xd79133)
#1 0x00007f9426575ad4 llvm::sys::RunSignalHandlers() (/usr/lib/llvm/22/lib64/libLLVM.so.22.0git3feb6f97+0xd75ad4)
#2 0x00007f9426575c89 (/usr/lib/llvm/22/lib64/libLLVM.so.22.0git3feb6f97+0xd75c89)
#3 0x00007f94252639d0 (/usr/lib64/libc.so.6+0x3d9d0)
#4 0x00007f94252cadc7 cfree (/usr/lib64/libc.so.6+0xa4dc7)
#5 0x00007f942c56db34 llvm::StringSet<llvm::MallocAllocator>::~StringSet() (/var/tmp/portage/llvm-core/clang-22.0.0.9999/work/x/y/clang-abi_x86_64.amd64/lib64/libclang-cpp.so.22.0git3feb6f97+0xb6db34)
#6 0x00007f9425265aab __cxa_finalize (/usr/lib64/libc.so.6+0x3faab)
#7 0x00007f942c48ebf7 (/var/tmp/portage/llvm-core/clang-22.0.0.9999/work/x/y/clang-abi_x86_64.amd64/lib64/libclang-cpp.so.22.0git3feb6f97+0xa8ebf7)
```

https://github.com/llvm/llvm-project/pull/149148