[clang] [LifetimeSafety] Revamp test suite using unittests (PR #149158)

Sat Jul 26 04:57:25 PDT 2025

llvm-ci wrote:

LLVM Buildbot has detected a new failure on builder `clang-with-lto-ubuntu` running on `as-worker-91` while building `clang` at step 6 "build-stage1-compiler".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/49/builds/1922

<details>
<summary>Here is the relevant piece of the build log for the reference</summary>

```
Step 6 (build-stage1-compiler) failure: build (failure)
...
/home/buildbot/as-worker-91/clang-with-lto-ubuntu/llvm-project/clang/include/clang/Serialization/ASTReader.h:319:8: note:   by ‘virtual bool clang::ChainedASTReaderListener::visitInputFile(llvm::StringRef, bool, bool, bool)’
  319 |   bool visitInputFile(StringRef Filename, bool isSystem,
      |        ^~~~~~~~~~~~~~
759.542 [1339/72/5222] Linking CXX executable bin/clang-import-test
760.230 [1338/72/5223] Building CXX object tools/clang/unittests/CMakeFiles/AllClangUnitTests.dir/StaticAnalyzer/AnalyzerOptionsTest.cpp.o
762.244 [1337/72/5224] Building CXX object tools/clang/unittests/CMakeFiles/AllClangUnitTests.dir/Analysis/CloneDetectionTest.cpp.o
763.290 [1336/72/5225] Building CXX object tools/clang/unittests/CMakeFiles/AllClangUnitTests.dir/Parse/ParseHLSLRootSignatureTest.cpp.o
763.376 [1335/72/5226] Building CXX object tools/clang/unittests/CMakeFiles/AllClangUnitTests.dir/Driver/ToolChainTest.cpp.o
764.030 [1334/72/5227] Linking CXX executable bin/clang-installapi
764.420 [1333/72/5228] Building CXX object tools/clang/unittests/CMakeFiles/AllClangUnitTests.dir/Analysis/LifetimeSafetyTest.cpp.o
FAILED: tools/clang/unittests/CMakeFiles/AllClangUnitTests.dir/Analysis/LifetimeSafetyTest.cpp.o 
/usr/bin/c++ -DEXPERIMENTAL_KEY_INSTRUCTIONS -DGTEST_HAS_RTTI=0 -DLLVM_BUILD_STATIC -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I/home/buildbot/as-worker-91/clang-with-lto-ubuntu/build/stage1/tools/clang/unittests -I/home/buildbot/as-worker-91/clang-with-lto-ubuntu/llvm-project/clang/unittests -I/home/buildbot/as-worker-91/clang-with-lto-ubuntu/llvm-project/clang/include -I/home/buildbot/as-worker-91/clang-with-lto-ubuntu/build/stage1/tools/clang/include -I/home/buildbot/as-worker-91/clang-with-lto-ubuntu/build/stage1/include -I/home/buildbot/as-worker-91/clang-with-lto-ubuntu/llvm-project/llvm/include -I/home/buildbot/as-worker-91/clang-with-lto-ubuntu/llvm-project/clang/unittests/Tooling -I/home/buildbot/as-worker-91/clang-with-lto-ubuntu/llvm-project/third-party/unittest/googletest/include -I/home/buildbot/as-worker-91/clang-with-lto-ubuntu/llvm-project/third-party/unittest/googlemock/include -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wno-missing-field-initializers -pedantic -Wno-long-long -Wimplicit-fallthrough -Wno-uninitialized -Wno-nonnull -Wno-class-memaccess -Wno-redundant-move -Wno-pessimizing-move -Wno-noexcept-type -Wdelete-non-virtual-dtor -Wsuggest-override -Wno-comment -Wno-misleading-indentation -Wctad-maybe-unsupported -fdiagnostics-color -ffunction-sections -fdata-sections -fno-common -Woverloaded-virtual -O3 -DNDEBUG  -Wno-variadic-macros -fno-exceptions -funwind-tables -fno-rtti -Wno-suggest-override -std=c++17 -MD -MT tools/clang/unittests/CMakeFiles/AllClangUnitTests.dir/Analysis/LifetimeSafetyTest.cpp.o -MF tools/clang/unittests/CMakeFiles/AllClangUnitTests.dir/Analysis/LifetimeSafetyTest.cpp.o.d -o tools/clang/unittests/CMakeFiles/AllClangUnitTests.dir/Analysis/LifetimeSafetyTest.cpp.o -c /home/buildbot/as-worker-91/clang-with-lto-ubuntu/llvm-project/clang/unittests/Analysis/LifetimeSafetyTest.cpp
/home/buildbot/as-worker-91/clang-with-lto-ubuntu/llvm-project/clang/unittests/Analysis/LifetimeSafetyTest.cpp:70:28: error: declaration of ‘std::unique_ptr<clang::TestAST> clang::lifetimes::internal::{anonymous}::LifetimeTestRunner::TestAST’ changes meaning of ‘TestAST’ [-fpermissive]
   70 |   std::unique_ptr<TestAST> TestAST;
      |                            ^~~~~~~
In file included from /home/buildbot/as-worker-91/clang-with-lto-ubuntu/llvm-project/clang/unittests/Analysis/LifetimeSafetyTest.cpp:12:
/home/buildbot/as-worker-91/clang-with-lto-ubuntu/llvm-project/clang/include/clang/Testing/TestAST.h:72:7: note: ‘TestAST’ declared here as ‘class clang::TestAST’
   72 | class TestAST {
      |       ^~~~~~~
765.833 [1333/71/5229] Building CXX object tools/clang/unittests/CMakeFiles/AllClangUnitTests.dir/Analysis/MacroExpansionContextTest.cpp.o
765.917 [1333/70/5230] Building CXX object tools/clang/unittests/CMakeFiles/AllClangUnitTests.dir/Lex/PPCallbacksTest.cpp.o
766.300 [1333/69/5231] Building CXX object tools/clang/lib/Interpreter/CMakeFiles/obj.clangInterpreter.dir/Interpreter.cpp.o
766.632 [1333/68/5232] Building CXX object tools/clang/tools/clang-scan-deps/CMakeFiles/clang-scan-deps.dir/ClangScanDeps.cpp.o
In file included from /home/buildbot/as-worker-91/clang-with-lto-ubuntu/llvm-project/clang/include/clang/Tooling/DependencyScanning/ModuleDepCollector.h:19,
                 from /home/buildbot/as-worker-91/clang-with-lto-ubuntu/llvm-project/clang/include/clang/Tooling/DependencyScanning/DependencyScanningWorker.h:17,
                 from /home/buildbot/as-worker-91/clang-with-lto-ubuntu/llvm-project/clang/include/clang/Tooling/DependencyScanning/DependencyScanningTool.h:13,
                 from /home/buildbot/as-worker-91/clang-with-lto-ubuntu/llvm-project/clang/tools/clang-scan-deps/ClangScanDeps.cpp:15:
/home/buildbot/as-worker-91/clang-with-lto-ubuntu/llvm-project/clang/include/clang/Serialization/ASTReader.h:255:16: warning: ‘virtual bool clang::ASTReaderListener::visitInputFile(llvm::StringRef, llvm::StringRef, bool, bool, bool)’ was hidden [-Woverloaded-virtual]
  255 |   virtual bool visitInputFile(StringRef FilenameAsRequested, StringRef Filename,
      |                ^~~~~~~~~~~~~~
/home/buildbot/as-worker-91/clang-with-lto-ubuntu/llvm-project/clang/include/clang/Serialization/ASTReader.h:319:8: note:   by ‘virtual bool clang::ChainedASTReaderListener::visitInputFile(llvm::StringRef, bool, bool, bool)’
  319 |   bool visitInputFile(StringRef Filename, bool isSystem,
      |        ^~~~~~~~~~~~~~
766.790 [1333/67/5233] Linking CXX executable bin/clang-nvlink-wrapper
767.061 [1333/66/5234] Linking CXX executable bin/clang-sycl-linker
768.878 [1333/65/5235] Building CXX object tools/clang/unittests/CMakeFiles/AllClangUnitTests.dir/StaticAnalyzer/APSIntTypeTest.cpp.o
770.242 [1333/64/5236] Building CXX object tools/clang/unittests/CMakeFiles/AllClangUnitTests.dir/StaticAnalyzer/ConflictingEvalCallsTest.cpp.o
770.383 [1333/63/5237] Building CXX object tools/clang/unittests/CMakeFiles/AllClangUnitTests.dir/AST/ByteCode/BitcastBuffer.cpp.o
770.452 [1333/62/5238] Building CXX object tools/clang/tools/libclang/CMakeFiles/libclang.dir/CIndex.cpp.o
771.243 [1333/61/5239] Linking CXX executable bin/clang-linker-wrapper
771.597 [1333/60/5240] Linking CXX executable bin/clang-check
771.870 [1333/59/5241] Building CXX object tools/clang/unittests/CMakeFiles/AllClangUnitTests.dir/StaticAnalyzer/CallEventTest.cpp.o
772.159 [1333/58/5242] Building CXX object tools/clang/unittests/CMakeFiles/AllClangUnitTests.dir/StaticAnalyzer/BlockEntranceCallbackTest.cpp.o
772.363 [1333/57/5243] Building CXX object tools/clang/unittests/CMakeFiles/AllClangUnitTests.dir/StaticAnalyzer/ObjcBug-124477.cpp.o
772.549 [1333/56/5244] Building CXX object tools/clang/unittests/CMakeFiles/AllClangUnitTests.dir/StaticAnalyzer/Z3CrosscheckOracleTest.cpp.o
773.402 [1333/55/5245] Building CXX object tools/clang/unittests/CMakeFiles/AllClangUnitTests.dir/Analysis/FlowSensitive/CFGMatchSwitchTest.cpp.o
773.465 [1333/54/5246] Building CXX object tools/clang/unittests/CMakeFiles/AllClangUnitTests.dir/StaticAnalyzer/MemRegionDescriptiveNameTest.cpp.o
773.564 [1333/53/5247] Building CXX object tools/clang/unittests/CMakeFiles/AllClangUnitTests.dir/StaticAnalyzer/ExprEngineVisitTest.cpp.o
773.622 [1333/52/5248] Building CXX object tools/clang/unittests/CMakeFiles/AllClangUnitTests.dir/Analysis/FlowSensitive/CachedConstAccessorsLatticeTest.cpp.o

```

</details>

https://github.com/llvm/llvm-project/pull/149158