[clang-tools-extra] [clang-tidy] Added check 'bugprone-function-visibility-change' (PR #140086)

[Piotr Zegar via cfe-commits]

=?utf-8?q?Balázs_Kéri?= <balazs.keri at ericsson.com>,
=?utf-8?q?Balázs_Kéri?= <balazs.keri at ericsson.com>,
=?utf-8?q?Balázs_Kéri?= <balazs.keri at ericsson.com>,
=?utf-8?q?Balázs_Kéri?= <balazs.keri at ericsson.com>,
=?utf-8?q?Balázs_Kéri?= <balazs.keri at ericsson.com>,
=?utf-8?q?Balázs_Kéri?= <balazs.keri at ericsson.com>,
=?utf-8?q?Balázs_Kéri?= <balazs.keri at ericsson.com>,
=?utf-8?q?Balázs_Kéri?= <balazs.keri at ericsson.com>
Message-ID:
In-Reply-To: <llvm.org/llvm/llvm-project/pull/140086 at github.com>


https://github.com/PiotrZSL commented:

Overall looks fine, the only thing is name.

Main problem is that this doesn't look to be bugprone or readability.
Misc is an generic category, sometimes I missing "design" category in clang-tidy, right now many checks that fall into same category are actually in cppguidelines namespace but there is not rule for this thing.

As for a name of the check, maybe something like "misc-virtual-function-visibility-change-in-override" to make it more clear.

https://github.com/llvm/llvm-project/pull/140086