[clang] [Clang][RFC] Do not eat SFINAE diagnostics for explicit template arguments (PR #139066)

[via cfe-commits]

================
@@ -12166,6 +12174,15 @@ static void DiagnoseBadDeduction(Sema &S, NamedDecl *Found, Decl *Templated,
              diag::note_ovl_candidate_explicit_arg_mismatch_unnamed)
           << (index + 1);
     }
+
+    if (PartialDiagnosticAt *PDiag = DeductionFailure.getSFINAEDiagnostic()) {
+      unsigned DiagID =
----------------
Sirraide wrote:

> No, I think this patch should emit the diagnostic as-is and add a `//fixme: attach this diagnostic to the parent error`

Yeah, I’d go with that. I think it should be easier for me to come back and update the diagnostic after the fact.

https://github.com/llvm/llvm-project/pull/139066