amykhuang wrote: looks ok to me. Or do you think it would make more sense to put this check in `isKnownWindowsMSVCEnvironment()`? https://github.com/llvm/llvm-project/pull/150115