[clang] [LifetimeSafety] Revamp test suite using unittests (PR #149158)

Tue Jul 22 04:32:01 PDT 2025

llvm-ci wrote:

LLVM Buildbot has detected a new failure on builder `llvm-clang-key-instructions` running on `sie-linux-worker5` while building `clang` at step 5 "build-unified-tree".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/208/builds/2988

<details>
<summary>Here is the relevant piece of the build log for the reference</summary>

```
Step 5 (build-unified-tree) failure: build (failure)
...
178.175 [1386/10/5257] Building CXX object tools/clang/unittests/CMakeFiles/AllClangUnitTests.dir/Tooling/StandardLibraryTest.cpp.o
178.663 [1385/10/5258] Building CXX object tools/clang/unittests/CMakeFiles/AllClangUnitTests.dir/Tooling/DiagnosticsYamlTest.cpp.o
178.721 [1384/10/5259] Building CXX object tools/clang/unittests/CMakeFiles/AllClangUnitTests.dir/Tooling/ExecutionTest.cpp.o
178.762 [1383/10/5260] Building CXX object tools/clang/unittests/CMakeFiles/AllClangUnitTests.dir/Tooling/DependencyScanning/DependencyScanningFilesystemTest.cpp.o
178.803 [1382/10/5261] Building CXX object tools/clang/unittests/CMakeFiles/AllClangUnitTests.dir/Tooling/CompilationDatabaseTest.cpp.o
179.041 [1381/10/5262] Building CXX object tools/clang/unittests/CMakeFiles/AllClangUnitTests.dir/Tooling/QualTypeNamesTest.cpp.o
179.176 [1380/10/5263] Building CXX object tools/clang/unittests/CMakeFiles/AllClangUnitTests.dir/Tooling/HeaderAnalysisTest.cpp.o
179.212 [1379/10/5264] Building CXX object tools/clang/unittests/CMakeFiles/AllClangUnitTests.dir/Tooling/LexicallyOrderedRecursiveASTVisitorTest.cpp.o
179.234 [1378/10/5265] Building CXX object tools/clang/unittests/CMakeFiles/AllClangUnitTests.dir/Tooling/LookupTest.cpp.o
179.288 [1377/10/5266] Building CXX object tools/clang/unittests/CMakeFiles/AllClangUnitTests.dir/Analysis/LifetimeSafetyTest.cpp.o
FAILED: tools/clang/unittests/CMakeFiles/AllClangUnitTests.dir/Analysis/LifetimeSafetyTest.cpp.o 
/opt/ccache/bin/g++ -DEXPERIMENTAL_KEY_INSTRUCTIONS -DGTEST_HAS_RTTI=0 -DLLVM_BUILD_STATIC -D_DEBUG -D_GLIBCXX_ASSERTIONS -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I/home/buildbot/buildbot-root/llvm-ki/build/tools/clang/unittests -I/home/buildbot/buildbot-root/llvm-ki/llvm-project/clang/unittests -I/home/buildbot/buildbot-root/llvm-ki/llvm-project/clang/include -I/home/buildbot/buildbot-root/llvm-ki/build/tools/clang/include -I/home/buildbot/buildbot-root/llvm-ki/build/include -I/home/buildbot/buildbot-root/llvm-ki/llvm-project/llvm/include -I/home/buildbot/buildbot-root/llvm-ki/llvm-project/clang/unittests/Tooling -I/home/buildbot/buildbot-root/llvm-ki/llvm-project/third-party/unittest/googletest/include -I/home/buildbot/buildbot-root/llvm-ki/llvm-project/third-party/unittest/googlemock/include -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wno-missing-field-initializers -pedantic -Wno-long-long -Wimplicit-fallthrough -Wno-uninitialized -Wno-nonnull -Wno-class-memaccess -Wno-redundant-move -Wno-pessimizing-move -Wno-noexcept-type -Wdelete-non-virtual-dtor -Wsuggest-override -Wno-comment -Wno-misleading-indentation -Wctad-maybe-unsupported -fdiagnostics-color -ffunction-sections -fdata-sections -fno-common -Woverloaded-virtual -O3 -DNDEBUG  -Wno-variadic-macros -fno-exceptions -funwind-tables -fno-rtti -UNDEBUG -Wno-suggest-override -std=c++17 -MD -MT tools/clang/unittests/CMakeFiles/AllClangUnitTests.dir/Analysis/LifetimeSafetyTest.cpp.o -MF tools/clang/unittests/CMakeFiles/AllClangUnitTests.dir/Analysis/LifetimeSafetyTest.cpp.o.d -o tools/clang/unittests/CMakeFiles/AllClangUnitTests.dir/Analysis/LifetimeSafetyTest.cpp.o -c /home/buildbot/buildbot-root/llvm-ki/llvm-project/clang/unittests/Analysis/LifetimeSafetyTest.cpp
/home/buildbot/buildbot-root/llvm-ki/llvm-project/clang/unittests/Analysis/LifetimeSafetyTest.cpp:70:28: error: declaration of ‘std::unique_ptr<clang::TestAST> clang::lifetimes::internal::{anonymous}::LifetimeTestRunner::TestAST’ changes meaning of ‘TestAST’ [-fpermissive]
   70 |   std::unique_ptr<TestAST> TestAST;
      |                            ^~~~~~~
In file included from /home/buildbot/buildbot-root/llvm-ki/llvm-project/clang/unittests/Analysis/LifetimeSafetyTest.cpp:12:
/home/buildbot/buildbot-root/llvm-ki/llvm-project/clang/include/clang/Testing/TestAST.h:72:7: note: ‘TestAST’ declared here as ‘class clang::TestAST’
   72 | class TestAST {
      |       ^~~~~~~
179.296 [1377/9/5267] Building CXX object tools/clang/unittests/CMakeFiles/AllClangUnitTests.dir/Tooling/RangeSelectorTest.cpp.o
179.334 [1377/8/5268] Building CXX object tools/clang/unittests/CMakeFiles/AllClangUnitTests.dir/Tooling/DependencyScanning/DependencyScannerTest.cpp.o
In file included from /home/buildbot/buildbot-root/llvm-ki/llvm-project/clang/include/clang/Tooling/DependencyScanning/ModuleDepCollector.h:19,
                 from /home/buildbot/buildbot-root/llvm-ki/llvm-project/clang/include/clang/Tooling/DependencyScanning/DependencyScanningWorker.h:17,
                 from /home/buildbot/buildbot-root/llvm-ki/llvm-project/clang/include/clang/Tooling/DependencyScanning/DependencyScanningTool.h:13,
                 from /home/buildbot/buildbot-root/llvm-ki/llvm-project/clang/unittests/Tooling/DependencyScanning/DependencyScannerTest.cpp:17:
/home/buildbot/buildbot-root/llvm-ki/llvm-project/clang/include/clang/Serialization/ASTReader.h:255:16: warning: ‘virtual bool clang::ASTReaderListener::visitInputFile(llvm::StringRef, llvm::StringRef, bool, bool, bool)’ was hidden [-Woverloaded-virtual]
  255 |   virtual bool visitInputFile(StringRef FilenameAsRequested, StringRef Filename,
      |                ^~~~~~~~~~~~~~
/home/buildbot/buildbot-root/llvm-ki/llvm-project/clang/include/clang/Serialization/ASTReader.h:319:8: note:   by ‘virtual bool clang::ChainedASTReaderListener::visitInputFile(llvm::StringRef, bool, bool, bool)’
  319 |   bool visitInputFile(StringRef Filename, bool isSystem,
      |        ^~~~~~~~~~~~~~
179.634 [1377/7/5269] Building CXX object tools/clang/unittests/CMakeFiles/AllClangUnitTests.dir/Tooling/RecursiveASTVisitorTests/Attr.cpp.o
179.635 [1377/6/5270] Building CXX object tools/clang/unittests/CMakeFiles/AllClangUnitTests.dir/Tooling/RecursiveASTVisitorTests/BitfieldInitializer.cpp.o
179.865 [1377/5/5271] Building CXX object tools/clang/unittests/CMakeFiles/AllClangUnitTests.dir/Tooling/RecursiveASTVisitorTests/CallbacksLeaf.cpp.o
179.974 [1377/4/5272] Building CXX object tools/clang/unittests/CMakeFiles/AllClangUnitTests.dir/Tooling/RecursiveASTVisitorTests/CallbacksUnaryOperator.cpp.o
180.070 [1377/3/5273] Building CXX object tools/clang/unittests/CMakeFiles/AllClangUnitTests.dir/Tooling/RecursiveASTVisitorTests/CallbacksBinaryOperator.cpp.o
180.070 [1377/2/5274] Building CXX object tools/clang/unittests/CMakeFiles/AllClangUnitTests.dir/Tooling/RecursiveASTVisitorTests/CallbacksCompoundAssignOperator.cpp.o
180.070 [1377/1/5275] Building CXX object tools/clang/unittests/CMakeFiles/AllClangUnitTests.dir/Tooling/RecursiveASTVisitorTests/CallbacksCallExpr.cpp.o
ninja: build stopped: subcommand failed.

```

</details>

https://github.com/llvm/llvm-project/pull/149158