[libclc] [libclc] Expose `prepare_builtins_*` variables in top-level CMakeLists (PR #149657)
Michał Górny via cfe-commits
cfe-commits at lists.llvm.org
Sat Jul 19 08:57:14 PDT 2025
https://github.com/mgorny created https://github.com/llvm/llvm-project/pull/149657
Fix `libclc/utils/CMakeLists.txt` to expose `prepare_builtins_*` variables in parent scope. This was a regression introduced in #148815 where the code was moved into subdirectory, and the variables would no longer be accessible to calls in top-level CMakeLists, resulting in attempting to build targets with empty command:
```
[1566/1676] cd /var/tmp/portage/llvm-core/libclc-22.0.0.9999/work/libclc_build && -o /var/tmp/portage/llvm-core/libclc-22.0.0.9999/work/libclc_build/clspv--.bc /var/tmp/portage/llvm-core/libclc-22.0.0.9999/work/libclc_build/obj.libclc.dir/clspv--/builtins.opt.clspv--.bc
FAILED: clspv--.bc /var/tmp/portage/llvm-core/libclc-22.0.0.9999/work/libclc_build/clspv--.bc
cd /var/tmp/portage/llvm-core/libclc-22.0.0.9999/work/libclc_build && -o /var/tmp/portage/llvm-core/libclc-22.0.0.9999/work/libclc_build/clspv--.bc /var/tmp/portage/llvm-core/libclc-22.0.0.9999/work/libclc_build/obj.libclc.dir/clspv--/builtins.opt.clspv--.bc
/bin/sh: line 1: -o: command not found
```
>From 15b0841492f35aee3550209063e4a44363190b5b Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Micha=C5=82=20G=C3=B3rny?= <mgorny at gentoo.org>
Date: Sat, 19 Jul 2025 17:52:51 +0200
Subject: [PATCH] [libclc] Expose `prepare_builtins_*` variables in top-level
CMakeLists
Fix `libclc/utils/CMakeLists.txt` to expose `prepare_builtins_*`
variables in parent scope. This was a regression introduced in #148815
where the code was moved into subdirectory, and the variables would
no longer be accessible to calls in top-level CMakeLists, resulting
in attempting to build targets with empty command:
```
[1566/1676] cd /var/tmp/portage/llvm-core/libclc-22.0.0.9999/work/libclc_build && -o /var/tmp/portage/llvm-core/libclc-22.0.0.9999/work/libclc_build/clspv--.bc /var/tmp/portage/llvm-core/libclc-22.0.0.9999/work/libclc_build/obj.libclc.dir/clspv--/builtins.opt.clspv--.bc
FAILED: clspv--.bc /var/tmp/portage/llvm-core/libclc-22.0.0.9999/work/libclc_build/clspv--.bc
cd /var/tmp/portage/llvm-core/libclc-22.0.0.9999/work/libclc_build && -o /var/tmp/portage/llvm-core/libclc-22.0.0.9999/work/libclc_build/clspv--.bc /var/tmp/portage/llvm-core/libclc-22.0.0.9999/work/libclc_build/obj.libclc.dir/clspv--/builtins.opt.clspv--.bc
/bin/sh: line 1: -o: command not found
```
---
libclc/utils/CMakeLists.txt | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/libclc/utils/CMakeLists.txt b/libclc/utils/CMakeLists.txt
index ea1d9e9c8ef5f..6851ae16bda07 100644
--- a/libclc/utils/CMakeLists.txt
+++ b/libclc/utils/CMakeLists.txt
@@ -12,8 +12,8 @@ set( LLVM_LINK_COMPONENTS
if( LIBCLC_STANDALONE_BUILD )
add_llvm_executable( prepare_builtins prepare-builtins.cpp )
- set( prepare_builtins_exe prepare_builtins )
- set( prepare_builtins_target prepare_builtins )
+ set( prepare_builtins_exe prepare_builtins PARENT_SCOPE )
+ set( prepare_builtins_target prepare_builtins PARENT_SCOPE )
else()
add_llvm_utility( prepare_builtins prepare-builtins.cpp )
setup_host_tool( prepare_builtins PREPARE_BUILTINS prepare_builtins_exe prepare_builtins_target )
More information about the cfe-commits
mailing list