[clang] [NFC][Clang][FMV] Refactor sema checking of target_version/clones attributes. (PR #149067)

Tomas Matheson via cfe-commits cfe-commits at lists.llvm.org
Fri Jul 18 05:27:46 PDT 2025


================
@@ -1535,4 +1535,91 @@ bool SemaARM::areLaxCompatibleSveTypes(QualType FirstType,
          IsLaxCompatible(SecondType, FirstType);
 }
 
+enum FirstParam { Unsupported, Duplicate, Unknown };
+enum SecondParam { None, CPU, Tune };
+enum ThirdParam { Target, TargetClones, TargetVersion };
----------------
tmatheson-arm wrote:

This is a lot of ambiguous names added to the top-level namespace. I would either namespace them, or use `enum class`, or rename them to indicate they are something to do with target_version/target_clones attributes. Are they even used though?

https://github.com/llvm/llvm-project/pull/149067


More information about the cfe-commits mailing list