[clang] [AST] Remove an unnecessary cast (NFC) (PR #149338)

Kazu Hirata via cfe-commits cfe-commits at lists.llvm.org
Thu Jul 17 13:09:24 PDT 2025


https://github.com/kazutakahirata updated https://github.com/llvm/llvm-project/pull/149338

>From eebc7c508a56b53f651523b3199e8f6c765eb808 Mon Sep 17 00:00:00 2001
From: Kazu Hirata <kazu at google.com>
Date: Thu, 17 Jul 2025 08:07:26 -0700
Subject: [PATCH 1/2] [AST] Remove an unnecessary cast (NFC)

getFinallyStmt() already returns ObjCAtFinallyStmt *.
---
 clang/lib/AST/StmtPrinter.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/clang/lib/AST/StmtPrinter.cpp b/clang/lib/AST/StmtPrinter.cpp
index be02bdde38a3d..5d4c8370dfb5f 100644
--- a/clang/lib/AST/StmtPrinter.cpp
+++ b/clang/lib/AST/StmtPrinter.cpp
@@ -610,7 +610,7 @@ void StmtPrinter::VisitObjCAtTryStmt(ObjCAtTryStmt *Node) {
     }
   }
 
-  if (auto *FS = static_cast<ObjCAtFinallyStmt *>(Node->getFinallyStmt())) {
+  if (auto *FS = Node->getFinallyStmt()) {
     Indent() << "@finally";
     if (auto *CS = dyn_cast<CompoundStmt>(FS->getFinallyBody())) {
       PrintRawCompoundStmt(CS);

>From a5c8742c91aad3dbce141dfe31e08787591b95d1 Mon Sep 17 00:00:00 2001
From: Kazu Hirata <kazu at google.com>
Date: Thu, 17 Jul 2025 12:50:54 -0700
Subject: [PATCH 2/2] Address a comment.

---
 clang/lib/AST/StmtPrinter.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/clang/lib/AST/StmtPrinter.cpp b/clang/lib/AST/StmtPrinter.cpp
index 5d4c8370dfb5f..6ba5ec89964a9 100644
--- a/clang/lib/AST/StmtPrinter.cpp
+++ b/clang/lib/AST/StmtPrinter.cpp
@@ -610,7 +610,7 @@ void StmtPrinter::VisitObjCAtTryStmt(ObjCAtTryStmt *Node) {
     }
   }
 
-  if (auto *FS = Node->getFinallyStmt()) {
+  if (ObjCAtFinallyStmt *FS = Node->getFinallyStmt()) {
     Indent() << "@finally";
     if (auto *CS = dyn_cast<CompoundStmt>(FS->getFinallyBody())) {
       PrintRawCompoundStmt(CS);



More information about the cfe-commits mailing list