[clang] [Clang] Rework creating offloading toolchains (PR #125556)

[Joseph Huber via cfe-commits]

================
@@ -14,14 +14,14 @@
 // RUN:   | FileCheck %s --check-prefix=NO-OUTPUT-ERROR
 // RUN:   not %clang -### --target=x86_64-unknown-linux-gnu -nogpulib --offload-new-driver --offload-arch=native --amdgpu-arch-tool=%t/amdgpu_arch_fail -x hip %s 2>&1 \
 // RUN:   | FileCheck %s --check-prefix=NO-OUTPUT-ERROR
-// NO-OUTPUT-ERROR: error: cannot determine amdgcn architecture{{.*}}; consider passing it via '--offload-arch'
+// NO-OUTPUT-ERROR: error: cannot determine hip architecture{{.*}}; consider passing it via '--offload-arch'
----------------
jhuber6 wrote:

Yeah, I can reword them a bit. Mostly it just comes from the fact that now it's a generic 'offload-arch' utility instead of two separate ones we can't as easily make a distinction on which architecture it failed on.

https://github.com/llvm/llvm-project/pull/125556