[clang-tools-extra] [clang-tidy] add modernize-use-constexpr check (PR #146553)

[Baranov Victor via cfe-commits]

================
@@ -0,0 +1,972 @@
+//===--- UseConstexprCheck.cpp - clang-tidy--------------------------------===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
+//
+//===----------------------------------------------------------------------===//
+
+#include "UseConstexprCheck.h"
+#include "../utils/ASTUtils.h"
+#include "../utils/LexerUtils.h"
+#include "clang/AST/ASTContext.h"
+#include "clang/AST/ASTTypeTraits.h"
+#include "clang/AST/Decl.h"
+#include "clang/AST/DeclBase.h"
----------------
vbvictor wrote:

Do we need all these headers? Seems like `DeclBase.h` must be a part of `Decl.h`
Same with `Stmt`, `ASTMatchers` etc. IMO we can have indirect includes here, https://llvm.org/docs/CodingStandards.html#include-as-little-as-possible.

https://github.com/llvm/llvm-project/pull/146553