[clang] [Clang] FunctionEffects: Make a separate diagnostic group for redeclarations/overrides where effects are implicit. (PR #148690)

[via cfe-commits]

github-actions[bot] wrote:

<!--LLVM CODE FORMAT COMMENT: {clang-format}-->


:warning: C/C++ code formatter, clang-format found issues in your code. :warning:

<details>
<summary>
You can test this locally with the following command:
</summary>

``````````bash
git-clang-format --diff HEAD~1 HEAD --extensions cpp -- clang/lib/Sema/SemaDeclCXX.cpp clang/test/Sema/attr-nonblocking-sema.cpp
``````````

</details>

<details>
<summary>
View the diff from clang-format here.
</summary>

``````````diff
diff --git a/clang/lib/Sema/SemaDeclCXX.cpp b/clang/lib/Sema/SemaDeclCXX.cpp
index 090a1d9d2..3f3ba7b32 100644
--- a/clang/lib/Sema/SemaDeclCXX.cpp
+++ b/clang/lib/Sema/SemaDeclCXX.cpp
@@ -18700,8 +18700,9 @@ bool Sema::CheckOverridingFunctionAttributes(CXXMethodDecl *New,
                                                    NewFT->getParamTypes(), EPI);
           New->setType(ModQT);
           if (Errs.empty()) {
-            // A warning here is somewhat pedantic, in a different warning group.
-            // Skip this if there was already a merge conflict, which is more serious.
+            // A warning here is somewhat pedantic, in a different warning
+            // group. Skip this if there was already a merge conflict, which is
+            // more serious.
             Diag(New->getLocation(), diag::warn_mismatched_func_effect_override)
                 << Diff.effectName();
             Diag(Old->getLocation(), diag::note_overridden_virtual_function)

``````````

</details>


https://github.com/llvm/llvm-project/pull/148690