[clang-tools-extra] [clang-tidy] Improve integer comparison by matching valid expressions outside implicitCastExpr for use-integer-sign-comparison (PR #144240)
Baranov Victor via cfe-commits
cfe-commits at lists.llvm.org
Sat Jul 12 14:22:21 PDT 2025
================
@@ -112,14 +115,17 @@ void UseIntegerSignComparisonCheck::registerPPCallbacks(
void UseIntegerSignComparisonCheck::check(
const MatchFinder::MatchResult &Result) {
const auto *SignedCastExpression =
- Result.Nodes.getNodeAs<ImplicitCastExpr>("sIntCastExpression");
- assert(SignedCastExpression);
+ Result.Nodes.getNodeAs<CastExpr>("sIntCastExpression");
+ const auto *UnsignedCastExpression =
+ Result.Nodes.getNodeAs<CastExpr>("uIntCastExpression");
+ const auto *CastExpression =
----------------
vbvictor wrote:
```suggestion
const CastExpr *CastExpression =
```
https://github.com/llvm/llvm-project/pull/144240
More information about the cfe-commits
mailing list