[clang] [HLSL][RootSignature] Implement diagnostic for missed comma (PR #147350)

Justin Bogner via cfe-commits cfe-commits at lists.llvm.org
Wed Jul 9 09:16:28 PDT 2025


================
@@ -34,3 +34,7 @@ void bad_root_signature_5() {}
 // expected-error at +1 {{expected ')' to denote end of parameters, or, another valid parameter of RootConstants}}
 [RootSignature(MultiLineRootSignature)]
 void bad_root_signature_6() {}
+
+// expected-error at +1 {{expected end of stream to denote end of parameters, or, another valid parameter of RootSignature}}
+[RootSignature("RootFlags() RootConstants(b0, num32BitConstants = 1))")]
----------------
bogner wrote:

Does this also have an extra `)`? We should make sure we only have the error we're trying to detect here.

https://github.com/llvm/llvm-project/pull/147350


More information about the cfe-commits mailing list