[clang] [clang-tools-extra] [libcxx] [lldb] [Clang] Make the SizeType, SignedSizeType and PtrdiffType be named sugar types instead of built-in types (PR #143653)

[Erich Keane via cfe-commits]

================
@@ -7248,6 +7248,12 @@ QualType TreeTransform<Derived>::TransformDependentBitIntType(
   return Result;
 }
 
+template <typename Derived>
+QualType TreeTransform<Derived>::TransformPredefinedSugarType(
+    TypeLocBuilder &TLB, PredefinedSugarTypeLoc TL) {
+  llvm_unreachable("This type does not need to be transformed.");
----------------
erichkeane wrote:

I commented there, we probably DO have to transform this for folks using `libclang` (typically with AlwaysREbuild/etc).  BUT since you dont have a good test for it, we can wait for it to cause a problem I guess.  I'd vastly prefer having an implementation if we can come up with a test that tries to instantiate one of these.

https://github.com/llvm/llvm-project/pull/143653