[clang] [clang-tools-extra] [clang]: Propagate `*noreturn` attributes in `CFG` (PR #146355)

[via cfe-commits]

github-actions[bot] wrote:

<!--LLVM CODE FORMAT COMMENT: {clang-format}-->


:warning: C/C++ code formatter, clang-format found issues in your code. :warning:

<details>
<summary>
You can test this locally with the following command:
</summary>

``````````bash
git-clang-format --diff HEAD~1 HEAD --extensions cpp,h -- clang-tools-extra/test/clang-tidy/checkers/bugprone/unchecked-optional-access.cpp clang/include/clang/AST/Decl.h clang/lib/AST/Decl.cpp clang/lib/Analysis/CFG.cpp clang/lib/Analysis/FlowSensitive/TypeErasedDataflowAnalysis.cpp clang/lib/StaticAnalyzer/Checkers/NoReturnFunctionChecker.cpp clang/unittests/Analysis/FlowSensitive/TypeErasedDataflowAnalysisTest.cpp
``````````

</details>

<details>
<summary>
View the diff from clang-format here.
</summary>

``````````diff
diff --git a/clang/lib/Analysis/CFG.cpp b/clang/lib/Analysis/CFG.cpp
index bc4789121..ea8a7df1e 100644
--- a/clang/lib/Analysis/CFG.cpp
+++ b/clang/lib/Analysis/CFG.cpp
@@ -41,8 +41,8 @@
 #include "llvm/ADT/APSInt.h"
 #include "llvm/ADT/ArrayRef.h"
 #include "llvm/ADT/DenseMap.h"
-#include "llvm/ADT/ScopeExit.h"
 #include "llvm/ADT/STLExtras.h"
+#include "llvm/ADT/ScopeExit.h"
 #include "llvm/ADT/SetVector.h"
 #include "llvm/ADT/SmallPtrSet.h"
 #include "llvm/ADT/SmallVector.h"
diff --git a/clang/lib/StaticAnalyzer/Checkers/NoReturnFunctionChecker.cpp b/clang/lib/StaticAnalyzer/Checkers/NoReturnFunctionChecker.cpp
index 834bd81c2..8dd46bafa 100644
--- a/clang/lib/StaticAnalyzer/Checkers/NoReturnFunctionChecker.cpp
+++ b/clang/lib/StaticAnalyzer/Checkers/NoReturnFunctionChecker.cpp
@@ -50,45 +50,45 @@ void NoReturnFunctionChecker::checkPostCall(const CallEvent &CE,
       BuildSinks = getFunctionExtInfo(C->getType()).getNoReturn();
   }
 
- if (!BuildSinks && CE.isGlobalCFunction()) {
-   if (const IdentifierInfo *II = CE.getCalleeIdentifier()) {
-     // HACK: Some functions are not marked noreturn, and don't return.
-     //  Here are a few hardwired ones.  If this takes too long, we can
-     //  potentially cache these results.
-     //
-     // (!) In case of function list update, please also update
-     // CFGBuilder::VisitCallExpr (CFG.cpp)
-     BuildSinks =
-         llvm::StringSwitch<bool>(StringRef(II->getName()))
-             .Case("exit", true)
-             .Case("abort", true)
-             .Case("panic", true)
-             .Case("error", true)
-             .Case("Assert", true)
-             // FIXME: This is just a wrapper around throwing an exception.
-             //  Eventually inter-procedural analysis should handle this
-             //  easily.
-             .Case("ziperr", true)
-             .Case("assfail", true)
-             .Case("db_error", true)
-             .Case("__assert", true)
-             .Case("__assert2", true)
-             // For the purpose of static analysis, we do not care that
-             //  this MSVC function will return if the user decides to
-             //  continue.
-             .Case("_wassert", true)
-             .Case("__assert_rtn", true)
-             .Case("__assert_fail", true)
-             .Case("dtrace_assfail", true)
-             .Case("yy_fatal_error", true)
-             .Case("_XCAssertionFailureHandler", true)
-             .Case("_DTAssertionFailureHandler", true)
-             .Case("_TSAssertionFailureHandler", true)
-             .Case("__builtin_trap", true)
-             .Case("__builtin_unreachable", true)
-             .Default(false);
-   }
- }
+  if (!BuildSinks && CE.isGlobalCFunction()) {
+    if (const IdentifierInfo *II = CE.getCalleeIdentifier()) {
+      // HACK: Some functions are not marked noreturn, and don't return.
+      //  Here are a few hardwired ones.  If this takes too long, we can
+      //  potentially cache these results.
+      //
+      // (!) In case of function list update, please also update
+      // CFGBuilder::VisitCallExpr (CFG.cpp)
+      BuildSinks =
+          llvm::StringSwitch<bool>(StringRef(II->getName()))
+              .Case("exit", true)
+              .Case("abort", true)
+              .Case("panic", true)
+              .Case("error", true)
+              .Case("Assert", true)
+              // FIXME: This is just a wrapper around throwing an exception.
+              //  Eventually inter-procedural analysis should handle this
+              //  easily.
+              .Case("ziperr", true)
+              .Case("assfail", true)
+              .Case("db_error", true)
+              .Case("__assert", true)
+              .Case("__assert2", true)
+              // For the purpose of static analysis, we do not care that
+              //  this MSVC function will return if the user decides to
+              //  continue.
+              .Case("_wassert", true)
+              .Case("__assert_rtn", true)
+              .Case("__assert_fail", true)
+              .Case("dtrace_assfail", true)
+              .Case("yy_fatal_error", true)
+              .Case("_XCAssertionFailureHandler", true)
+              .Case("_DTAssertionFailureHandler", true)
+              .Case("_TSAssertionFailureHandler", true)
+              .Case("__builtin_trap", true)
+              .Case("__builtin_unreachable", true)
+              .Default(false);
+    }
+  }
 
   if (BuildSinks)
     C.generateSink(C.getState(), C.getPredecessor());

``````````

</details>


https://github.com/llvm/llvm-project/pull/146355