[clang] [Modules] fix assert in hasInitWithSideEffects (PR #146468)

[via cfe-commits]

github-actions[bot] wrote:

<!--LLVM CODE FORMAT COMMENT: {clang-format}-->


:warning: C/C++ code formatter, clang-format found issues in your code. :warning:

<details>
<summary>
You can test this locally with the following command:
</summary>

``````````bash
git-clang-format --diff HEAD~1 HEAD --extensions cpp,h -- clang/test/Modules/var-init-side-effects-modulemap.cpp clang/include/clang/AST/Decl.h clang/include/clang/AST/ExternalASTSource.h clang/include/clang/Sema/MultiplexExternalSemaSource.h clang/include/clang/Serialization/ASTReader.h clang/lib/AST/Decl.cpp clang/lib/Sema/MultiplexExternalSemaSource.cpp clang/lib/Serialization/ASTReader.cpp clang/lib/Serialization/ASTReaderDecl.cpp clang/lib/Serialization/ASTWriter.cpp clang/lib/Serialization/ASTWriterDecl.cpp
``````````

</details>

<details>
<summary>
View the diff from clang-format here.
</summary>

``````````diff
diff --git a/clang/lib/AST/Decl.cpp b/clang/lib/AST/Decl.cpp
index a22721d7e..e0362245d 100644
--- a/clang/lib/AST/Decl.cpp
+++ b/clang/lib/AST/Decl.cpp
@@ -2447,9 +2447,10 @@ bool VarDecl::hasInitWithSideEffects() const {
   EvaluatedStmt *ES = ensureEvaluatedStmt();
   if (!ES->CheckedForSideEffects) {
     const Expr *E = getInit();
-    ES->HasSideEffects = E->HasSideEffects(getASTContext()) &&
-             // We can get a value-dependent initializer during error recovery.
-             (E->isValueDependent() || !evaluateValue());
+    ES->HasSideEffects =
+        E->HasSideEffects(getASTContext()) &&
+        // We can get a value-dependent initializer during error recovery.
+        (E->isValueDependent() || !evaluateValue());
     ES->CheckedForSideEffects = true;
   }
   return ES->HasSideEffects;

``````````

</details>


https://github.com/llvm/llvm-project/pull/146468