[clang] [llvm] [NFC][HLSL][DirectX] Let `HLSLRootSignature` reuse the `dxbc` defined enums (PR #145986)

Justin Bogner via cfe-commits cfe-commits at lists.llvm.org
Wed Jul 2 12:32:12 PDT 2025


================
@@ -127,6 +127,7 @@ TEST_F(ParseHLSLRootSignatureTest, ValidParseEmptyTest) {
 }
 
 TEST_F(ParseHLSLRootSignatureTest, ValidParseDTClausesTest) {
+  using FlagT = llvm::dxbc::DescriptorRangeFlags;
----------------
bogner wrote:

I wouldn't rename this to `FlagT`, but instead just introduce the `DescriptorRangeFlags` name to the scope. That is:
```suggestion
  using llvm::dxbc::DescriptorRangeFlags;
```

Then we can use `DescriptorRangeFlags::DataStaticWhileSetAtExecute` and the like without explicitly writing out the `llvm::dxbc::` namespace every time, which improves readability and in this case actually simplifies the diff quite a bit.

https://github.com/llvm/llvm-project/pull/145986


More information about the cfe-commits mailing list