[clang] 524f090 - [alpha.webkit.UncountedCallArgsChecker] Treat CFEqual as a safe function (#146369)

[via cfe-commits]

Author: Rob Buis
Date: 2025-07-01T13:57:53+01:00
New Revision: 524f0903064c7ffd1a1f3b3b6f7d5da31151bfca

URL: https://github.com/llvm/llvm-project/commit/524f0903064c7ffd1a1f3b3b6f7d5da31151bfca
DIFF: https://github.com/llvm/llvm-project/commit/524f0903064c7ffd1a1f3b3b6f7d5da31151bfca.diff

LOG: [alpha.webkit.UncountedCallArgsChecker] Treat CFEqual as a safe function (#146369)

CFEqual is a trivial function, so treat it as safe.

Added: 
    clang/test/Analysis/Checkers/WebKit/call-args-safe-functions.mm

Modified: 
    clang/lib/StaticAnalyzer/Checkers/WebKit/RawPtrRefCallArgsChecker.cpp
    clang/test/Analysis/Checkers/WebKit/objc-mock-types.h

Removed: 
    


################################################################################
diff  --git a/clang/lib/StaticAnalyzer/Checkers/WebKit/RawPtrRefCallArgsChecker.cpp b/clang/lib/StaticAnalyzer/Checkers/WebKit/RawPtrRefCallArgsChecker.cpp
index 6bc39ab565041..764e2c640feb8 100644
--- a/clang/lib/StaticAnalyzer/Checkers/WebKit/RawPtrRefCallArgsChecker.cpp
+++ b/clang/lib/StaticAnalyzer/Checkers/WebKit/RawPtrRefCallArgsChecker.cpp
@@ -294,7 +294,7 @@ class RawPtrRefCallArgsChecker
     if (name == "adoptRef" || name == "getPtr" || name == "WeakPtr" ||
         name == "is" || name == "equal" || name == "hash" || name == "isType" ||
         // FIXME: Most/all of these should be implemented via attributes.
-        name == "equalIgnoringASCIICase" ||
+        name == "CFEqual" || name == "equalIgnoringASCIICase" ||
         name == "equalIgnoringASCIICaseCommon" ||
         name == "equalIgnoringNullity" || name == "toString")
       return true;

diff  --git a/clang/test/Analysis/Checkers/WebKit/call-args-safe-functions.mm b/clang/test/Analysis/Checkers/WebKit/call-args-safe-functions.mm
new file mode 100644
index 0000000000000..7ccc0d61f0acf
--- /dev/null
+++ b/clang/test/Analysis/Checkers/WebKit/call-args-safe-functions.mm
@@ -0,0 +1,12 @@
+// RUN: %clang_analyze_cc1 -analyzer-checker=alpha.webkit.UncountedCallArgsChecker -verify %s
+// expected-no-diagnostics
+
+#include "objc-mock-types.h"
+
+CGImageRef provideImage();
+
+Boolean cfe(CFTypeRef obj)
+{
+  return CFEqual(obj, provideImage());
+}
+

diff  --git a/clang/test/Analysis/Checkers/WebKit/objc-mock-types.h b/clang/test/Analysis/Checkers/WebKit/objc-mock-types.h
index 9e4356a71f1b5..09b303961fd6a 100644
--- a/clang/test/Analysis/Checkers/WebKit/objc-mock-types.h
+++ b/clang/test/Analysis/Checkers/WebKit/objc-mock-types.h
@@ -45,6 +45,7 @@ CFDictionaryRef CFDictionaryCreateCopy(CFAllocatorRef allocator, CFDictionaryRef
 CFDictionaryRef CFDictionaryCreateMutableCopy(CFAllocatorRef allocator, CFIndex capacity, CFDictionaryRef theDict);
 CFIndex CFDictionaryGetCount(CFDictionaryRef theDict);
 Boolean CFDictionaryContainsKey(CFDictionaryRef theDict, const void *key);
+Boolean CFEqual(CFTypeRef, CFTypeRef);
 Boolean CFDictionaryContainsValue(CFDictionaryRef theDict, const void *value);
 const void *CFDictionaryGetValue(CFDictionaryRef theDict, const void *key);
 void CFDictionaryAddValue(CFMutableDictionaryRef theDict, const void *key, const void *value);