[clang] [analyzer] Avoid unnecessary super region invalidation in `CStringChecker` (PR #146212)

[Balazs Benics via cfe-commits]

https://github.com/steakhal commented:

Thanks for the detailed PR summary. It makes sense. I had to think about it carefully but I agree with the motivation.
When I looked at the code it looked really complicated. Probably more than I expected it to be.

I think adding another bool parameter to the already crowded function is not ideal. We should look for some other way, maybe a different overload, or restructuring the code in other ways.


https://github.com/llvm/llvm-project/pull/146212