[clang-tools-extra] [modularize] Use std::tie to implement operator< (NFC) (PR #146220)

via cfe-commits cfe-commits at lists.llvm.org
Sat Jun 28 08:49:22 PDT 2025


llvmbot wrote:


<!--LLVM PR SUMMARY COMMENT-->

@llvm/pr-subscribers-clang-tools-extra

Author: Kazu Hirata (kazutakahirata)

<details>
<summary>Changes</summary>

std::tie clearly expresses the intent while slightly shortening the
code.


---
Full diff: https://github.com/llvm/llvm-project/pull/146220.diff


1 Files Affected:

- (modified) clang-tools-extra/modularize/Modularize.cpp (+1-1) 


``````````diff
diff --git a/clang-tools-extra/modularize/Modularize.cpp b/clang-tools-extra/modularize/Modularize.cpp
index 2a90c5e3f6782..1da531a4aefa4 100644
--- a/clang-tools-extra/modularize/Modularize.cpp
+++ b/clang-tools-extra/modularize/Modularize.cpp
@@ -459,7 +459,7 @@ struct HeaderEntry {
     return !(X == Y);
   }
   friend bool operator<(const HeaderEntry &X, const HeaderEntry &Y) {
-    return X.Loc < Y.Loc || (X.Loc == Y.Loc && X.Name < Y.Name);
+    return std::tie(X.Loc, X.Name) < std::tie(Y.Loc, Y.Name);
   }
   friend bool operator>(const HeaderEntry &X, const HeaderEntry &Y) {
     return Y < X;

``````````

</details>


https://github.com/llvm/llvm-project/pull/146220


More information about the cfe-commits mailing list