[clang] [Clang][ByteCode][NFC] Avoid copies by using move in Disasm.cpp (PR #146127)
via cfe-commits
cfe-commits at lists.llvm.org
Fri Jun 27 11:01:36 PDT 2025
llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT-->
@llvm/pr-subscribers-clang
Author: Shafik Yaghmour (shafik)
<details>
<summary>Changes</summary>
Static analysis flagged some cases we could avoid copies by using std::move in Disasm.cpp.
---
Full diff: https://github.com/llvm/llvm-project/pull/146127.diff
1 Files Affected:
- (modified) clang/lib/AST/ByteCode/Disasm.cpp (+4-4)
``````````diff
diff --git a/clang/lib/AST/ByteCode/Disasm.cpp b/clang/lib/AST/ByteCode/Disasm.cpp
index a3eecd06369b1..f64501f4a31e8 100644
--- a/clang/lib/AST/ByteCode/Disasm.cpp
+++ b/clang/lib/AST/ByteCode/Disasm.cpp
@@ -63,7 +63,7 @@ template <> inline std::string printArg<Floating>(Program &P, CodePtr &OpPC) {
std::string S;
llvm::raw_string_ostream SS(S);
- SS << Result;
+ SS << std::move(Result);
return S;
}
@@ -81,7 +81,7 @@ inline std::string printArg<IntegralAP<false>>(Program &P, CodePtr &OpPC) {
std::string Str;
llvm::raw_string_ostream SS(Str);
- SS << Result;
+ SS << std::move(Result);
return Str;
}
@@ -99,7 +99,7 @@ inline std::string printArg<IntegralAP<true>>(Program &P, CodePtr &OpPC) {
std::string Str;
llvm::raw_string_ostream SS(Str);
- SS << Result;
+ SS << std::move(Result);
return Str;
}
@@ -109,7 +109,7 @@ template <> inline std::string printArg<FixedPoint>(Program &P, CodePtr &OpPC) {
std::string Result;
llvm::raw_string_ostream SS(Result);
- SS << F;
+ SS << std::move(F);
return Result;
}
``````````
</details>
https://github.com/llvm/llvm-project/pull/146127
More information about the cfe-commits
mailing list