[clang] [PS5][Driver] Allow selection of CRT with `-L` (PR #145869)

Jeremy Morse via cfe-commits cfe-commits at lists.llvm.org
Fri Jun 27 06:01:57 PDT 2025


================
@@ -200,12 +200,10 @@
 // CHECK-NO-TARGETLIB-SAME: "-L."
 
 // RUN: mkdir -p %t.dir/myroot/target/lib
-// RUN: touch %t.dir/myroot/target/lib/crti.o
 // RUN: env SCE_PROSPERO_SDK_DIR=%t.dir/myroot %clang --target=x64_64-sie-ps5 %s -### -Luser 2>&1 | FileCheck --check-prefixes=CHECK-TARGETLIB %s
 // RUN: %clang --target=x64_64-sie-ps5 %s -### -Luser --sysroot=%t.dir/myroot 2>&1 | FileCheck --check-prefixes=CHECK-TARGETLIB %s
 
 // CHECK-TARGETLIB: {{ld(\.exe)?}}"
 // CHECK-TARGETLIB-SAME: "-Luser"
 // CHECK-TARGETLIB-SAME: "-L{{.*}}myroot{{/|\\\\}}target{{/|\\\\}}lib"
 // CHECK-TARGETLIB-SAME: "-L."
----------------
jmorse wrote:

Just to check the thinking: we don't need to check how the linker is directed to crti.o, these check lines are purely about ensuring the correct `-L` flags come out of the driver? (Seeing deleted lines suggests to me we're losing coverage, but I suppose it's not truly meaningful coverage).

https://github.com/llvm/llvm-project/pull/145869


More information about the cfe-commits mailing list