https://github.com/Michael137 commented: LGTM (modulo the question about one of the message strings) I'll let @delcypher comment on whether all his concerns have been addressed https://github.com/llvm/llvm-project/pull/145967