[clang] [llvm] [NFC][analyzer] Remove Z3-as-constraint-manager hacks from lit test code (PR #145731)

[Donát Nagy via cfe-commits]

================
@@ -123,26 +123,10 @@ S getS();
 S *getSP();
 
 void testReferenceAddress(int &x) {
-// FIXME: Move non-zero reference assumption out of RangeConstraintManager.cpp:422
----------------
NagyDonat wrote:

This FIXME asks for ensuring that some logic is applied in all constraint managers and not just the range-based one. However, now and in the foreseeable future the range-based constraint manager is the only functional one, so there is no point in bothering with this. (Also, the current contents of the 422th line and its neighborhood are completely unrelated to this FIXME, and I didn't have patience to look it up in an older revision.)

https://github.com/llvm/llvm-project/pull/145731