[clang] [llvm] Add support for Windows Secure Hot-Patching (redo) (PR #145565)

Alexandre Ganea via cfe-commits cfe-commits at lists.llvm.org
Wed Jun 25 07:28:48 PDT 2025


aganea wrote:

> Would it be sufficient to change the `/Fo...` argument to `-Fo...` ?

You actually have to add hyphens before %s in the tests, such as:

`// RUN: not %clang_cl -c --target=x86_64-windows-msvc -O2 /Z7 -fms-secure-hotpatch-functions-file=%S/this-file-is-intentionally-missing-do-not-create-it.txt /Fo%t.obj — %s 2>&1 | FileCheck %sˋ

> Also, why was this not caught during the CI jobs for the PR? Can something be changed so that it would be caught during CI?

This needs a unique file system setup, such as running inside a /opt folder, but I assume this could be replicated on the pre-commit CI. Would you mind filling an issue please?

https://github.com/llvm/llvm-project/pull/145565


More information about the cfe-commits mailing list