[clang] Revert "[clang][dataflow] Expose simple access to child StorageLocation presence." (PR #145710)

[Samira Bakon via cfe-commits]

https://github.com/bazuzi created https://github.com/llvm/llvm-project/pull/145710

Reverts llvm/llvm-project#145520

Exposed function is no longer needed and side-stepped the intended contract that the present children are the same set returned by `getModeledFields()` and presence shouldn't need to be queried for arbitrary fields.

>From 5ef48b36e5ebc5e0cd1058a502c7ef0cd9347d15 Mon Sep 17 00:00:00 2001
From: Samira Bakon <bazuzi at google.com>
Date: Wed, 25 Jun 2025 10:17:15 -0400
Subject: [PATCH] =?UTF-8?q?Revert=20"[clang][dataflow]=20Expose=20simple?=
 =?UTF-8?q?=20access=20to=20child=20StorageLocation=20prese=E2=80=A6"?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

This reverts commit 09b43a5a862f453aabd95ec01e0b53c46ca3e340.
---
 clang/include/clang/Analysis/FlowSensitive/StorageLocation.h | 2 --
 1 file changed, 2 deletions(-)

diff --git a/clang/include/clang/Analysis/FlowSensitive/StorageLocation.h b/clang/include/clang/Analysis/FlowSensitive/StorageLocation.h
index 8b263b16d5b1e..8fcc6a44027a0 100644
--- a/clang/include/clang/Analysis/FlowSensitive/StorageLocation.h
+++ b/clang/include/clang/Analysis/FlowSensitive/StorageLocation.h
@@ -168,8 +168,6 @@ class RecordStorageLocation final : public StorageLocation {
     return {Children.begin(), Children.end()};
   }
 
-  bool hasChild(const ValueDecl &D) const { return Children.contains(&D); }
-
 private:
   FieldToLoc Children;
   SyntheticFieldMap SyntheticFields;