[clang] [llvm] [HLSL][RootSignature] Add `hlsl-rootsig-ver` option to specify root signature version (PR #144813)

Justin Bogner via cfe-commits cfe-commits at lists.llvm.org
Tue Jun 24 13:56:59 PDT 2025


================
@@ -66,17 +66,17 @@ void addDxilValVersion(StringRef ValVersionStr, llvm::Module &M) {
   DXILValMD->addOperand(Val);
 }
 
-void addRootSignature(ArrayRef<llvm::hlsl::rootsig::RootElement> Elements,
+void addRootSignature(llvm::dxbc::RootSignatureVersion RootSigVer,
+                      ArrayRef<llvm::hlsl::rootsig::RootElement> Elements,
                       llvm::Function *Fn, llvm::Module &M) {
   auto &Ctx = M.getContext();
+  IRBuilder<> Builder(Ctx);
----------------
bogner wrote:

`IRB` is also a common name for IRBuilders. Might make the code slightly clearer to have `IRB` and `RSBuilder` so you never need to wonder which builder `Builder` is when reading this.

https://github.com/llvm/llvm-project/pull/144813


More information about the cfe-commits mailing list