[clang] [analyzer] Enforce not making overly complicated symbols (PR #144327)

[Donát Nagy via cfe-commits]

https://github.com/NagyDonat commented:

Thanks for your patience in this review! I'm happy to see the additional simplifications coming from just wrapping the over-complicated symbol instead of storing its parts separately. (I see that it's a bit inelegant to construct the very thing that we're trying to avoid, but this is the pragmatic choice...)

I don't expect any performance issues (the "frozen" complex symbols shouldn't be problematic if they aren't traversed), but performance testing is never completely useless.

https://github.com/llvm/llvm-project/pull/144327